[Ksecretservice-devel] playground/base/ksecretservice

[Michael Leupold]

Hi Dario,

2010/9/12, Dario Freddi <drf at kde.org>:
> SVN commit 1174498 by dafre:
>
> CCMAIL: lemma at confuego.org
> CCMAIL: kde at rusu.info
>
> First attempt at the Kwl Importer. Many problems & FIXMEs & TODOs, but it's
> a barebone. It is nothing but a KCompositeJob spawning a set of
> sub-KJobs which convert one KWallet each. The process will be further
> optimized once everything will work, including progress and stuff.
> Michael, I'm waiting for your feedback on this.
>
> It just compiles but does not run on purpose. However, the nice thing about
> this job is that it works just like the nepomuk converter, so it is silent
> and displays
> progress in the tray.
>
> Once the TODOs are solved, I think it should be ready. Valentin, I think I
> should be fine in completing this alone, also because apparently there is
> not much work to be done.
>
>  M  +1 -0      CMakeLists.txt
>  A             kwlimporter (directory)
>  A             kwlimporter/CMakeLists.txt
>  A             kwlimporter/importsinglewalletjob.cpp   [License: GPL (v2/3)]
>  A             kwlimporter/importsinglewalletjob.h   [License: GPL (v2/3)]
>  A             kwlimporter/kwlimporterjob.cpp   [License: GPL (v2/3)]
>  A             kwlimporter/kwlimporterjob.h   [License: GPL (v2/3)]
>
>
> --- trunk/playground/base/ksecretservice/CMakeLists.txt #1174497:1174498
> @@ -27,3 +27,4 @@
>  ADD_SUBDIRECTORY (frontend)
>  ADD_SUBDIRECTORY (lib)
>  ADD_SUBDIRECTORY (ui)
> +add_subdirectory (kwlimporter)

First (shallow) review:
You won't be able to use the KWallet::Wallet client API for importing
the wallet. It will be rewritten to use the new service by the time
it's released. Also, kwalletd will no longer be around by then.
Reading the wallet is equally simple using the kwallet backend library
though. You can just make a copy of
kdebase/runtime/kwalletd/kwalletbackend and use it to read the wallet.

Regards,
Michael