Review Request 127208: Remove Q3ValueList usage from RecipeDB::importUSDADatabase()

[Albert Astals Cid]

> On Feb. 29, 2016, 7:34 a.m., José Manuel  Santamaría Lema wrote:
> > Indeed QList seems appropiate to replace Q3ValueList, tested the patch with SQLite and works.
> > 
> > Thanks for the patch! Keep them coming ;)
> 
> R.Harish  Navnit wrote:
>     It seems like I lack privileges to push to this repo. Can you do it on my behalf ?
> 
> Albert Astals Cid wrote:
>     You should not lack the privileges since KDE commit policy is repo-wide.
>     
>     Which error do you get?
> 
> R.Harish  Navnit wrote:
>     This one : https://paste.kde.org/pswqqszwu
> 
> Albert Astals Cid wrote:
>     What does 
>       cat .git/config  | grep url
>     return when on the krecipes folder?
> 
> R.Harish  Navnit wrote:
>     it returns an http url and a git:// url pointing to anongit.kde.org/krecipes. https://paste.kde.org/pkjfxxd3d

Noone can push to anongit, your download is wrongly setup, fix that and you'll be able to push. See https://techbase.kde.org/Development/Git/Configuration#URL_Renaming and then just download kde:krecipes


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127208/#review92880
-----------------------------------------------------------


On Feb. 28, 2016, 1:39 p.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127208/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2016, 1:39 p.m.)
> 
> 
> Review request for Krecipes and José Manuel  Santamaría Lema.
> 
> 
> Repository: krecipes
> 
> 
> Description
> -------
> 
> Replace the Q3ValueList occurences in RecipeDB::importUSDADatabase() with QList.
> QList preferred over QLinkedList since it's faster and convenient.
> 
> 
> Diffs
> -----
> 
>   src/backends/recipedb.cpp aa38c6b4b602544cfbfe3b7db73a8b9c59abe518 
> 
> Diff: https://git.reviewboard.kde.org/r/127208/diff/
> 
> 
> Testing
> -------
> 
> Successfully built and re-ran the setup wizard. Imports work fine.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/krecipes-devel/attachments/20160328/157afff1/attachment.html>