Review Request 127208: Remove Q3ValueList usage from RecipeDB::importUSDADatabase()
R.Harish Navnit
harishnavnit at gmail.com
Fri Mar 25 13:20:51 UTC 2016
> On Feb. 29, 2016, 1:04 p.m., José Manuel Santamaría Lema wrote:
> > Indeed QList seems appropiate to replace Q3ValueList, tested the patch with SQLite and works.
> >
> > Thanks for the patch! Keep them coming ;)
It seems like I lack privileges to push to this repo. Can you do it on my behalf ?
- R.Harish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127208/#review92880
-----------------------------------------------------------
On Feb. 28, 2016, 7:09 p.m., R.Harish Navnit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127208/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2016, 7:09 p.m.)
>
>
> Review request for Krecipes and José Manuel Santamaría Lema.
>
>
> Repository: krecipes
>
>
> Description
> -------
>
> Replace the Q3ValueList occurences in RecipeDB::importUSDADatabase() with QList.
> QList preferred over QLinkedList since it's faster and convenient.
>
>
> Diffs
> -----
>
> src/backends/recipedb.cpp aa38c6b4b602544cfbfe3b7db73a8b9c59abe518
>
> Diff: https://git.reviewboard.kde.org/r/127208/diff/
>
>
> Testing
> -------
>
> Successfully built and re-ran the setup wizard. Imports work fine.
>
>
> Thanks,
>
> R.Harish Navnit
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/krecipes-devel/attachments/20160325/b45c2ebc/attachment.html>
More information about the Krecipes-devel
mailing list