Review Request 127208: Remove Q3ValueList usage from RecipeDB::importUSDADatabase()

[José Manuel Santamaría Lema]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127208/#review92880
-----------------------------------------------------------


Ship it!




Indeed QList seems appropiate to replace Q3ValueList, tested the patch with SQLite and works.

Thanks for the patch! Keep them coming ;)

- José Manuel  Santamaría Lema


On Feb. 28, 2016, 1:39 p.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127208/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2016, 1:39 p.m.)
> 
> 
> Review request for Krecipes and José Manuel  Santamaría Lema.
> 
> 
> Repository: krecipes
> 
> 
> Description
> -------
> 
> Replace the Q3ValueList occurences in RecipeDB::importUSDADatabase() with QList.
> QList preferred over QLinkedList since it's faster and convenient.
> 
> 
> Diffs
> -----
> 
>   src/backends/recipedb.cpp aa38c6b4b602544cfbfe3b7db73a8b9c59abe518 
> 
> Diff: https://git.reviewboard.kde.org/r/127208/diff/
> 
> 
> Testing
> -------
> 
> Successfully built and re-ran the setup wizard. Imports work fine.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/krecipes-devel/attachments/20160229/f7c59d41/attachment.html>