[kplato] Moving Forward

[Stephen]

Thomas

I've made a start trying to compile some of this code.

Only managed KPTNode so far, but have some amendments for you:

kptnode.h

In the declarations for addDependNode and insertDependNode there
is a reference to ParentRelationship, should this be
TimingRelationship or should the enumeration definition be
changed to ParentRelationship or was something else intended.

In several function declarations there are references to
m_dependNodes, but there are only declarations for
m_dependChildNodes and m_dependParentNodes.  I wasn't sure of
your intentions here, whether the functions should relate to a
single list, should there be duplicate functions for the other
list, or should the functions work on both of the lists together.

The implementation of endTime(), should be { return m_endTime; }

kptnode.cc

Definition of the constructor should just be KPTNode::KPTNode()
{  ( I think )

In the constructor the member variables are initialised.  In the
class definition they are declared as variables, but in the
constructor they are being initialised with new as if they were
pointers.  Should the class definition be pointers?

There is another reference to ParentRelation, again this either
needs to be TimingRelation or the enumeration definition needs to
be changed.

QTime( .. ) requires at least 2 parameters, hours and minutes and
optionally seconds and milliseconds.



It still will not compile cleanly, complaining about the forward
definitions of KPTRisk and KPTRelation

/usr/lib/qt2/include/qlist.h: In method `void
QList<KPTRisk>::deleteItem(void *)':
kptnode.cc:69:   instantiated from here
/usr/lib/qt2/include/qlist.h:104: invalid use of undefined type
`class KPTRisk'
kptnode.h:27: forward declaration of `class KPTRisk'
/usr/lib/qt2/include/qlist.h: In method `void
QList<KPTRelation>::deleteItem(void *)':
kptnode.cc:69:   instantiated from here
/usr/lib/qt2/include/qlist.h:104: invalid use of undefined type
`class KPTRelation'
kptnode.h:28: forward declaration of `class KPTRelation'

regards

Steve




Thomas Zander wrote:
> 
> On Sun, Jul 01, 2001 at 08:26:35PM +0000, Stephen wrote:
> > Thanks Thomas,
> >
> > A starting point for us all.
> >
> > Just been reading through and my only comment at the moment is,
> > should we be implementing the addChildNode and addDependNode in
> > KPTNode as insertChildNode and insertDependNode with an index to
> > define where in the list of children it will appear.
> 
> Right, done in CVS.
> 
> >
> > Thomas Zander wrote:
> > > Right, guess what I just spent half my sunday doing ;)
> > >
> > > I just put this into CVS (koffice/kplato) But I also attached a tar for
> > > convinience.
> > > Feel free to comment, sent patches, burn me to the ground and basically
> > > get things going.
> 
> --
> Thomas Zander                                            zander@earthling.net
> The only thing worse than failure is the fear of trying something new
> _______________________________________________
> kplato mailing list
> kplato@master.kde.org
> http://master.kde.org/mailman/listinfo/kplato