[KPhotoAlbum] Crash with Thumbnail Settings button

[Johannes Zarl-Zierl]

Hi,

I've pushed the fix - the error (a missing check of a return value) was 
introduced during the latest round of porting away from deprecated APIs. I've 
also checked all related changes and this seems to be the only problematic 
change...

Cheers,
  Johannes


Am Dienstag, 21. Jänner 2020, 16:18:13 CET schrieb Johannes Zarl-Zierl:
> It's actually worse - the crash happens every time one opens the settings
> dialog.
> 
> I already have a simple fix - I'm just checking why it happens and whether
> there is more to it than it seems before pushing the fix...
> 
>   Johannes
> 
> Am Dienstag, 21. Jänner 2020, 02:06:15 CET schrieb Robert Krawitz:
> > If I click the Thumbnail Settings button at the bottom right of the
> > thumbnail display, I reliably get the following crash (Qt 5.14, KDE
> > framework 5.66):
> > 
> > #0  0x00007fffe8d777a0 in QListWidgetItem::listModel() const () at
> > /usr/lib64/libQt5Widgets.so.5 #1  0x00007fffe8d77835 in
> > QListWidgetItem::setSelected(bool) () at /usr/lib64/libQt5Widgets.so.5 #2
> > 0x000000000049754f in Settings::CategoryPage::resetInterface() () #3
> > 0x000000000049a04e in Settings::CategoryPage::CategoryPage(QWidget*) () #4
> > 0x0000000000494be9 in Settings::SettingsDialog::SettingsDialog(QWidget*)
> > ()
> > #5  0x00000000005590e0 in MainWindow::Window::slotOptions() ()
> > #6  0x00000000005592a6 in
> > QtPrivate::QFunctorSlotObject<MainWindow::Window::setupStatusBar()::{lambd
> > a
> > ()#1}, 0, QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*,
> > QObject*, void**, bool*) () #7  0x00007fffe7c0d9e7 in  () at
> > /usr/lib64/libQt5Core.so.5
> > #8  0x00007fffe7c0d9e7 in  () at /usr/lib64/libQt5Core.so.5
> > #9  0x00007fffe8bc3b12 in QAbstractButton::clicked(bool) () at
> > /usr/lib64/libQt5Widgets.so.5 #10 0x00007fffe8bc3d2a in  () at
> > /usr/lib64/libQt5Widgets.so.5
> > #11 0x00007fffe8bc510a in  () at /usr/lib64/libQt5Widgets.so.5
> > #12 0x00007fffe8bc52fd in QAbstractButton::mouseReleaseEvent(QMouseEvent*)
> > () at /usr/lib64/libQt5Widgets.so.5
> > #13 0x00007fffe8cb6c5a in QToolButton::mouseReleaseEvent(QMouseEvent*) ()
> > 
> >     at /usr/lib64/libQt5Widgets.so.5
> > 
> > #14 0x00007fffe8b18dd8 in QWidget::event(QEvent*) () at
> > /usr/lib64/libQt5Widgets.so.5 #15 0x00007fffe8cb6cf4 in
> > QToolButton::event(QEvent*) () at /usr/lib64/libQt5Widgets.so.5 #16
> > 0x00007fffe8ad7bac in QApplicationPrivate::notify_helper(QObject*,
> > QEvent*)
> > () at /usr/lib64/libQt5Widgets.so.5
> > #17 0x00007fffe8adffc8 in QApplication::notify(QObject*, QEvent*) ()
> > 
> >     at /usr/lib64/libQt5Widgets.so.5
> > 
> > #18 0x00007fffe7bd27b8 in QCoreApplication::notifyInternal2(QObject*,
> > QEvent*) () at /usr/lib64/libQt5Core.so.5
> > #19 0x00007fffe8ade64f in QApplicationPrivate::sendMouseEvent(QWidget*,
> > QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool,
> > bool) () at /usr/lib64/libQt5Widgets.so.5 #20 0x00007fffe8b333e1 in  () at
> > /usr/lib64/libQt5Widgets.so.5
> > #21 0x00007fffe8b3624a in  () at /usr/lib64/libQt5Widgets.so.5
> > #22 0x00007fffe8ad7bac in QApplicationPrivate::notify_helper(QObject*,
> > QEvent*) () at /usr/lib64/libQt5Widgets.so.5
> > #23 0x00007fffe8adf180 in QApplication::notify(QObject*, QEvent*) ()
> > 
> >     at /usr/lib64/libQt5Widgets.so.5
> > 
> > #24 0x00007fffe7bd27b8 in QCoreApplication::notifyInternal2(QObject*,
> > QEvent*) () at /usr/lib64/libQt5Core.so.5
> > #25 0x00007fffe81d2315 in
> > QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::M
> > o
> > useEvent*) () at /usr/lib64/libQt5Gui.so.5 #26 0x00007fffe81d3445 in
> > QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePri
> > v
> > ate::WindowSystemEvent*) () at /usr/lib64/libQt5Gui.so.5 #27
> > 0x00007fffe81ac69b in
> > QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessE
> > v
> > entsFlag>) () at /usr/lib64/libQt5Gui.so.5 #28 0x00007fffc8abefaa in  ()
> > at
> > /usr/lib64/libQt5XcbQpa.so.5
> > #29 0x00007fffdbeb1e87 in g_main_context_dispatch () at
> > /usr/lib64/libglib-2.0.so.0 #30 0x00007fffdbeb2230 in  () at
> > /usr/lib64/libglib-2.0.so.0
> > #31 0x00007fffdbeb22bc in g_main_context_iteration () at
> > /usr/lib64/libglib-2.0.so.0 #32 0x00007fffe7c31a1c in
> > QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>)
> > () at /usr/lib64/libQt5Core.so.5 #33 0x00007fffe7bd103a in
> > QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () at
> > /usr/lib64/libQt5Core.so.5
> > #34 0x00007fffe7bda7b0 in QCoreApplication::exec() () at
> > /usr/lib64/libQt5Core.so.5 #35 0x0000000000463e3d in main ()
> 
> _______________________________________________
> KPhotoAlbum mailing list
> KPhotoAlbum at mail.kdab.com
> https://mail.kdab.com/mailman/listinfo/kphotoalbum