[KPhotoAlbum] Annotation performance improvments

[Robert Krawitz]

On Tue, 14 Jan 2020 18:44:01 -0500 (EST), Robert Krawitz wrote:
> On Tue, 14 Jan 2020 23:03:24 +0100, Johannes Zarl-Zierl wrote:
>> Hi,
>>
>> Am Dienstag, 14. Jänner 2020, 01:02:10 CET schrieb Robert Krawitz:
>>> I've created a new 'annotation-performance' branch with these
>>> improvements.  If everyone agrees that they're safe, I think it would
>>> be good to get this into 5.6; it will greatly improve performance of
>>> annotation for people with a lot of images and groups.
>>
>> So far, there's three commits:
>> 252bc62b Improve calculation of max text height
>> 49a8a47e Improve performance of annotation dialog
>> b7f378e6 Speed up computing new selection
>>
>> The two last ones seem safe on first sight.
>> The first one (252bc62b) computes consistently too low numbers, leading to clipped text. Returning grps.length() - 1 instead leads to occasional wasted space, but seems otherwise lead to correct results.
>
> I think I see what's going on -- items at top level don't have a
> folder (I can reproduce it by searching only for items with no
> folder).  That should be an easy fix.

Fixed.
-- 
Robert Krawitz                                     <rlk at alum.mit.edu>

***  MIT Engineers   A Proud Tradition   http://mitathletics.com  ***
Member of the League for Programming Freedom  --  http://ProgFree.org
Project lead for Gutenprint   --    http://gimp-print.sourceforge.net

"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton