[KPhotoAlbum] Some minor cleanups

[Johannes Zarl-Zierl]

Hi Robert,

Now is a good time to merge those changes (plus the parallel-md5 branch) to 
master. If you want extra scrutiny on some parts or on everything just tell me 
and I'll do a proper review...

Cheers,
  Johannes


Am Montag, 24. Februar 2020, 00:25:23 CET schrieb Robert Krawitz:
> I have a few minor cleanups in my work tree:
> 
> 1) Minor simplification/cleanup to counting max # of categories in
> cell geometry (inline the static function, basically; the compiler
> doesn't quite seem to do it).
> 
> 2) Mionr rearrangement of hasChanges() in the annotation dialog code
> to do the fast checks first and skip the slow ones.  Also removed the
> checkOptions argument to hasChanges, because it was only passed in as
> other that the default in a way that resulted in that code never being
> used.
> 
> 3) Typedef the ImageDB map data types, so there aren't a bunch of
> files all having to explicitly use the template forms.  I also want to
> change those to QHash rather than QMap, because I don't beieve any of
> them rely on the ordering and a QHash appears to be marginally faster
> in my test case.  Regardless of whether we decide to do that, I
> believe those data types should all be typedef'd.