[KPhotoAlbum] Keywords with id=0?

Johannes Zarl-Zierl johannes at zarl-zierl.at
Sun Dec 15 17:59:59 GMT 2019

Am Sonntag, 15. Dezember 2019, 18:43:08 CET schrieb Robert Krawitz:
> On Sun, 15 Dec 2019 17:31:48 +0100, Johannes Zarl-Zierl wrote:
> [...]
> > You can leave the warning out here completely, because now this is
> > expected behaviour.
> If we stay with this approach, I want to both keep the warning and the
> guard.
> First the warning: nothing should attempt to set an invalid value; we
> want to know if something's trying to do that.  Failing silently might
> cause other unintended behavior, and in any event, if something's
> breaking the rules, we want to know.
> Secondly, the guard: again, we don't want to perform an invalid
> operation (which is within the same class, no non-local knowledge
> here).  And we don't want renaming a tag or group, which is perfectly
> legal, to generate a warning indicating an illegal operation.

I see where you're coming from. Sounds good to me.

More information about the Kphotoalbum mailing list