[KPhotoAlbum] "Maintenance" -> "Statistics.." does something completely different
Johannes Zarl-Zierl
johannes at zarl-zierl.at
Fri Nov 30 22:03:05 GMT 2018
Hi Andreas,
Thanks for the report and patch! I've merged it to git master...
Somehow, the accidental removal of the now re-added line slipped code review.
The button should work fine in older releases of KPhotoAlbum; KPhotoAlbum 5.4
is affected by this.
Johannes
Am Sonntag, 25. November 2018, 18:28:27 CET schrieb Andreas Schleth:
> Hi Johannes,
>
> in the latest few git-master revisions I found a strange menu entry
> below "maintenance":
>
> "Statistics.." This led to the dialog "Do you really want to rebuild
> all thumbnails?" - so clearly a misnomer.
>
> I found the culprit in MainWindow/Window.cpp: The line to call the
> statistics dialog was simply missing.
>
> Attached please find a patch against today's git-master to re-introduce
> the statistics dialog. It seems to do what it is called.
>
> However, I do not have the faintest idea what I really did :-) I just
> copied the line with buildThumbs above and exchanged the appropriate
> strings.
>
> Could You please check if this makes any sense?
>
> Andreas
More information about the Kphotoalbum
mailing list