[KPhotoAlbum] Fix for compile error in RemoteConnection.cpp

Robert Krawitz rlk at alum.mit.edu
Thu Jun 14 23:07:38 BST 2018


On Thu, 14 Jun 2018 23:14:09 +0200, Johannes Zarl-Zierl wrote:
> Am Donnerstag, 14. Juni 2018, 14:10:19 CEST schrieb Robert Krawitz:
>> Don't know that this is the correct fix for versions of Qt prior to
>> 5.11, so I'm not just blindly pushing it.
>
> There's already a proposed patch:
> https://phabricator.kde.org/D13329
>
> I'd say that cgiboudeaux is correct in that the qPrintable is not necessary in this context.
> Given the note regarding qUtf8Printable() in the docs [1], qPrintable seems like an incorrect choice in the first place.
>
> [1] https://doc.qt.io/qt-5/qtglobal.html#qPrintable]

lgtm
-- 
Robert Krawitz                                     <rlk at alum.mit.edu>

***  MIT Engineers   A Proud Tradition   http://mitathletics.com  ***
Member of the League for Programming Freedom  --  http://ProgFree.org
Project lead for Gutenprint   --    http://gimp-print.sourceforge.net

"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton



More information about the Kphotoalbum mailing list