[KPhotoAlbum] load-performance and startup-performance

[Robert Krawitz]

On Thu, 12 Jul 2018 12:29:47 +0200, Johannes Zarl-Zierl wrote:
> Am Donnerstag, 12. Juli 2018, 02:40:36 CEST schrieb Robert Krawitz:
>> On Thu, 12 Jul 2018 01:45:47 +0200, Johannes Zarl-Zierl wrote:
>> There's also the startup-performance branch (which I just spotted a
>> very minor bug that I'm fixing in the MD5 stuff).
>
> Yes, I'm aware - I'll get to it asap (and then there's two other patchsets, too: Samuel Kay has 	a new HTML export, and Andreas Neustifter had an improvement to video-thumbnail creation IIRC).
>
>> > For the record, two minor issues remain that need fixing before the
>> > next release: (1) there's an unused member variable creating a
>> > warning message
>> 
>> Where's the warning?  I don't see it in the log.
>
> Clang 6.0.1 gives:
> DB/ImageScout.cpp:74:9: warning: private field 'm_index' is not used [-
> Wunused-private-field]
>     int m_index;

OK.

>> > (2) the implemenation of OptimizedFileList should be made less
>> > linux-specific
>> Yes, statvfs would be a better option here.  Unfortunately, statfs is
>> much less standardized than stat.
>
> It seems like you know your C library functions and syscalls better than me. Do you have time to improve cross-platform compatibility here?
> As far as I'm concerned, Linux and (Free)BSD should both be supported equally, if possible. Having a fallback that's possibly slower, but platform-agnostic is also great.(*)

This shouldn't be slower.  Given what it does, if it were
significantly slower I'd prefer to have it conditioned.

> (*) Regarding other platforms: Many(?) KDE applications also support Windows, but I don't have a build environment for that and as long as nobody pops up and wants to make a Windows port happen, I'm not investing my limited time into this. (I'll accept patches, though) I've also heard there's some people building for MacOs - the same rationale applies here.

I don't know Windows myself.  That may very well have to be different.
-- 
Robert Krawitz                                     <rlk at alum.mit.edu>

***  MIT Engineers   A Proud Tradition   http://mitathletics.com  ***
Member of the League for Programming Freedom  --  http://ProgFree.org
Project lead for Gutenprint   --    http://gimp-print.sourceforge.net

"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton