[KPhotoAlbum] load-performance and startup-performance

[Robert Krawitz]

On Thu, 12 Jul 2018 01:45:47 +0200, Johannes Zarl-Zierl wrote:
> Hi Robert,
>
> Am Sonntag, 8. Juli 2018, 00:40:33 CEST schrieb Robert Krawitz:
>> Has anyone had a chance to play with these some?  I'd like to get this
>> merged; it will really help people IMO.
>
> I've reviewed and merged the rest of the load-performance-stable
> branch now. I have to admit that I did not put too much scrutiny on
> the OptimizedFileList, though. At this point I think the feature is
> ready for a wider audience ;-)

There's also the startup-performance branch (which I just spotted a
very minor bug that I'm fixing in the MD5 stuff).

> For the record, two minor issues remain that need fixing before the
> next release: (1) there's an unused member variable creating a
> warning message

Where's the warning?  I don't see it in the log.

> (2) the implemenation of OptimizedFileList should be made less linux-specific

Yes, statvfs would be a better option here.  Unfortunately, statfs is
much less standardized than stat.

> I'll fix (1) some time this week, but with (2) I'll probably need some time to get a FreeBSD VM set up (I don't want to think of possible Windows compilation for now).
>
> See also:
> https://build.kde.org/view/Extragear/job/Extragear%20kphotoalbum%20kf5-qt5%20FreeBSDQt5.10/

-- 
Robert Krawitz                                     <rlk at alum.mit.edu>

***  MIT Engineers   A Proud Tradition   http://mitathletics.com  ***
Member of the League for Programming Freedom  --  http://ProgFree.org
Project lead for Gutenprint   --    http://gimp-print.sourceforge.net

"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton