[KPhotoAlbum] Search performance (at least) linear in number of search terms?

Robert Krawitz rlk at alum.mit.edu
Mon Jul 17 04:35:02 BST 2017


On Sun, 16 Jul 2017 23:50:43 +0200, Johannes Zarl-Zierl wrote:
> On Sonntag, 16. Juli 2017 09:53:37 CEST Tobias Leupold wrote:
>> In case of doubt, Johannes is the one to decide whether or not, but I think
>> this can be removed in favor of using Qt directly. Which does not only ��� as
>> you stated ��� speed up the code, but also simplify it.
>
> I don't think there is any doubt here: you both mentioned two concrete advantages and no obvious disadvantages. Go for it...

It was messier than I expected because there were a lot of uses of
StringSet, which was defined in Set.h.  I renamed Set.h to StringSet.h
and cleaned up the uses of Set.h (some of which were gratuitous).

I guess I could have done it the easy way and just removed Set.cpp and
everything but StringSet from Set.h, but I was a glutton for punishment.
-- 
Robert Krawitz                                     <rlk at alum.mit.edu>

***  MIT Engineers   A Proud Tradition   http://mitathletics.com  ***
Member of the League for Programming Freedom  --  http://ProgFree.org
Project lead for Gutenprint   --    http://gimp-print.sourceforge.net

"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-cleanup-stringset.patch
Type: application/octet-stream
Size: 14414 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20170716/4848fd8f/attachment.obj>


More information about the Kphotoalbum mailing list