[KPhotoAlbum] Multi-image annotation dialog annoyance

[Andreas Schleth]

On 29.11.2016 20:03, Reimar Imhof wrote:
> Am Montag, 28. November 2016, 22:23:23 CET schrieb Robert Krawitz:
>> On Mon, 28 Nov 2016 22:56:07 +0100, Johannes Zarl-Zierl wrote:
>>> So....
>>>
>>> I decided not to try and outsmart myself with the ImagePreview size. So
>>> far, it seems very promising:
>>>
>>> https://commits.kde.org/kphotoalbum/fec5cc9b7183fc1448e51056e8117dd7539c02
>>> e4
>>>
>>> The new code removes all guessing (and possible cyclic data dependencies)
>>> from the game. It is simpler, easier to understand and (most important of
>>> all) does what it is supposed to do.
>>>
>>> The only downside (and the reason I initially tried to be smart) is that
>>> by default, the preview wants to be as big as the image. That should be
>>> no problem, though, because the actual size is dependent on other factors
>>> as well...
>>>
>>> How does this work for you?
>> Worked fine for me (and eliminated some other problems with the dialog
>> changing when it received/lost focus).
> Hi,
> it's very strange - why does it work every where but not here? Just compiled
> latest version from git - no luck.
> Reimar
>
> _______________________________________________
> KPhotoAlbum mailing list
> KPhotoAlbum at mail.kdab.com
> https://mail.kdab.com/mailman/listinfo/kphotoalbum
>
Hi Reimar & Johannes,

just now, I tested the flickering issue on the demo Database with my 
previous git build (v5.0.1-16-gacef49e) and - tataa - I have seen the 
flicker!  Reimar, you are not alone.

* start a new KPA with a wholly new Demo Database (say "delete" after an 
earlier test).

* select all thumbnails

* hit crtl-2

* young blackie flickers.  Sometimes, when hovering the mouse above, the 
separator bar below the preview flickers too.

* resize the preview just a tiny bit and the flicker is gone and cannot 
be restored.

So I pulled the latest version (v5.0.1.-20-...) and there we have the 
flicker gone, but some odd resizing behavior. The image scales in steps. 
Sometimes it gets cropped.

--> Without looking at the code (using pure telepathy ;-): The original 
issue most probably is a coincidence, where a certain thumbnail size (as 
in the demo) combined with a certain window layout (default) triggers 
one of the most beloved > vs. >= or < vs. <= errors or something along 
the lines (0-255 = 256) vs. 255.  As the internal window frames take 
part in the flickering, I would not search this in KPA but somewhere 
deeper in the KDE/QT cellars.

--> Therefore, you might find it easier to change the default window 
layout by a few percent and be done, than to hunt the bug in KPA (or 
KDE/QT).  Maybe a canned, flickering version might help someone at 
KDE/QT to hunt down this issue from their side (revision -16- ... might do).

@Johannes:  As you are just touching the rescaling of the preview:

* I do not think the current state is satisfactory. Much too jumpy and 
not responsive. I prefer the old state.

* I would greatly appreciate, if the current scaling of the preview 
could be saved with a custom window layout.  I think, I even filed a bug 
(yes in 2014: https://bugs.kde.org/show_bug.cgi?id=340121).  In the 
earlier versions (4.1.1 and before) that was a feature in KPA, that 
seemingly dropped out after a QT interface change.

Happy debugging, Andreas

"...

The small girl smiles. One eyelid flickers.

She whips a pistol from her knickers.

..."  giyf