[KPhotoAlbum] gps search: a patch

[Johannes Zarl-Zierl]

Hello again,

I've cleaned the patch up a little for fellow reviewers. I did not yet have 
time for any real testing, though.

You added caching of the coordinates in DB::ImageInfo. I'm curious: did you 
get significant performance differences with/without caching for searching or 
for "regular" MapWidget use?
I'm asking because we initially did the same caching there, but there was no 
discernible performance difference...

Cheers,
  Johannes

On Sunday 31 May 2015 22:17:21 you wrote:
> Hello Reimar,
> 
> Thanks for the patch! Searching for GPS locations is certainly a nice
> feature.
> 
> I'll look into it as soon as possible (which should be some time this week)
> and give you some feedback. Maybe Tobias can also give some feedback...
> 
> Cheers,
>   Johannes
> 
> On Sunday 31 May 2015 21:59:55 Reimar Imhof wrote:
> > Hallo,
> > 
> > here you'll find a patch for a simple gps search.
> > 
> > It's included in the search dialog. The map comes up in standard pan mode
> > -
> > you can change that to region selection.
> > 
> > If you select a region you'll get images with gps coordinates in that
> > region. Images without gps info will not be found.
> > 
> > If you want to select images without gps info or don't care about gps you
> > just don't need to select a region. Or you could press the new "Remove
> > Search Region" button.
> > 
> > There is one little problem in
> > KGeoMap::GeoCoordinates DB::ImageInfo::coordinates() const
> > This runs an exifdb update if it's not version 2.
> > This update just takes a little time. That's why the first search
> > including
> > gps info might take some time. And there is no search progress bar...
> > 
> > 
> > Enhancements are welcome.
> > 
> > Reimar
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gpssearch-1-cleanup.patch
Type: text/x-patch
Size: 12315 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20150531/7bba65b3/attachment.bin>