[KPhotoAlbum] More patches

[Robert Krawitz]

On Sun, 9 Aug 2015 11:03:34 -0400, Robert Krawitz wrote:
> On Sat, 08 Aug 2015 13:17:46 +0200, Tobias Leupold wrote:
>> Hi Robert :-)
>>
>> I just wanted to try out your patches, but Miika is right: at least for the link-images patch, your code is _removed_ by it and not added, so I can't apply it.
>>
>> Would you be so kind to recreate the patches in the right "direction", so that we don't have to apply the changes by hand? Would be nice :-)
>
> I don't really like the current lens EXIF logic.  On many Canon
> cameras, Lens will work better than LensType.  For example, on the
> 300D:
>
> [1(rlk)|{!10}<dsl092-065-009>/altmnt/images/300d/dcim/101canon]
> $ exiv2 -pa img_0108.jpg |grep Lens
> Exif.CanonCs.LensType                        Short       1  (65535)
> Exif.CanonCs.Lens                            Short       3  28.0 - 135.0 mm

Here's what I've found from a variety of Canon cameras.  It's apparent
that for older cameras we need to look at Lens in addition to LensType.

PowerShot S3:

Exif.CanonCs.LensType                        Short       1  (65535)
Exif.CanonCs.Lens                            Short       3  6.0 - 72.0 mm

PowerShot SX1:

Exif.CanonCs.LensType                        Short       1  (65535)
Exif.CanonCs.Lens                            Short       3  5.0 - 100.0 mm

PowerShot A75:

Exif.CanonCs.LensType                        Short       1  (65535)
Exif.CanonCs.Lens                            Short       3  5.4 - 16.2 mm

EOS 300D:

Exif.CanonCs.LensType                        Short       1  (65535)
Exif.CanonCs.Lens                            Short       3  28.0 - 135.0 mm

EOS 20D:

Exif.CanonCs.LensType                        Short       1  (65535)
Exif.CanonCs.Lens                            Short       3  12.0 - 24.0 mm

EOS 7D (firmware 1.2):

Exif.CanonCs.LensType                        Short       1  Canon EF-S 18-135mm f/3.5-5.6 IS
Exif.CanonCs.Lens                            Short       3  18.0 - 135.0 mm
Exif.Canon.LensModel                         Ascii      70  EF-S18-135mm f/3.5-5.6 IS

EOS 7D (firmware 2.0):

Exif.CanonCs.LensType                        Short       1  Sigma 70-200mm f/2.8 EX DG APO OS HSM
Exif.CanonCs.Lens                            Short       3  70.0 - 200.0 mm
Exif.Canon.LensModel                         Ascii      74  70-200mm
Exif.Photo.LensSpecification                 Rational    4  70/1 200/1 0/1 0/1
Exif.Photo.LensModel                         Ascii       9  70-200mm

EOS 7D mkII:

Exif.CanonCs.LensType                        Short       1  Canon EF-S 18-135mm f/3.5-5.6 IS
Exif.CanonCs.Lens                            Short       3  18.0 - 135.0 mm
Exif.Canon.LensModel                         Ascii      74  EF-S18-135mm f/3.5-5.6 IS
Exif.Photo.LensSpecification                 Rational    4  18/1 135/1 0/1 0/1
Exif.Photo.LensModel                         Ascii      26  EF-S18-135mm f/3.5-5.6 IS

EOS M:

Exif.CanonCs.LensType                        Short       1  Canon EF-M 22mm f/2 STM
Exif.CanonCs.Lens                            Short       3  22.0 mm
Exif.Canon.LensModel                         Ascii      74  EF-M22mm f/2 STM
Exif.Photo.LensSpecification                 Rational    4  22/1 22/1 0/1 0/1
Exif.Photo.LensModel                         Ascii      17  EF-M22mm f/2 STM

-- 
Robert Krawitz                                     <rlk at alum.mit.edu>

***  MIT Engineers   A Proud Tradition   http://mitathletics.com  ***
Member of the League for Programming Freedom  --  http://ProgFree.org
Project lead for Gutenprint   --    http://gimp-print.sourceforge.net

"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton