[KPhotoAlbum] Fix krazy2 warnings

Johannes Zarl isilmendil at isilme.lupus.uberspace.de
Tue Aug 6 15:32:04 BST 2013


Hi Dominik,

There are still some issues with this patch:

 - In the AnnotationDialog, pressing return in the lineedits doesn't work 
anymore. I guess the easiest fix would be to emit 
QLineEdit::returnPressed() in addition to KLineEdit::returnPressed(QString).

 - Using KDialog messes with the layout of AnnotationDialog
   If you compare both versions, you'll see that the resizing behaviour is 
different (components dynamically adopt in the QDialog version)
   I'm not sure if this is inherent to KDialog, or if it can be worked around.

The rest looks good.

> P. S. : The missing source/destination prefix seem to be KDevelop's fault.

Ah, that explains it.


Cheers,
  Johannes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20130806/586619a6/attachment-0001.htm>


More information about the Kphotoalbum mailing list