[KPhotoAlbum] [PATCH 2/3] SettingsData: Default window geometry calculated

[Michael Witten]

I'm assuming you meant to post to the list, so I'll post my reply to
the list as well.

On 24 Sep 2008, at 10:49 AM, Jan Kundrát wrote:

> Well, KPhotoAlbum is already using one particular coding style. You

> might not like it, I might not like it, but well, the code's already

> here and this is not going to change.


Firstly,
there's not much of a coding style in KPhotoAlbum.

Secondly,
the code is changing; improvement is the goal. To say, "This is the
way it is, so this is how it shall remain" is unnecessarily limiting,
especially when that's one of the few reasons.

Thirdly,
nothing I'm doing is that radical.

> You might very well have great point in doing fancy indentation or

> artifying code in other ways; I could not care less, as long as we're

> speaking about KPA codebase, sorry :)


Thank you for the commendation. However, you didn't explain your apathy.

> Sneaking coding style changes through normal patches is just not good.


I resent that. I haven't tried to sneak anything by anyone.

> Perhaps we'd better aim on stabilizing the thing or adding new

> features and not at fighting about whitespace.


Stabilizing and adding features is precisely what I've been discussing
before this nonsensical effort to maintain some kind of status quo
that never existed to begin with.

> I'm going to revert these "coding style changes" (like long lines)

> unless someone powerful enough (hi Jesper, hi Henner, hi Tuomas)

> objects.


There are more than '"coding style changes" (like long lines)'.
Why don't you take the opportunity to look at the code (without
wrapping!), and I think you'll find it's neither harmful nor
offensive; if anything it is an improvement or better than what
has been proposed in the name of nothing important.