[KPhotoAlbum] [PATCH 2/3] SettingsData: Default window geometry calculated

Michael Witten mfwitten at MIT.EDU
Wed Sep 24 04:41:14 BST 2008


On 23 Sep 2008, at 3:33 PM, Henner Zeller wrote:

> The constant calculation in the beginning to estimate a useful size is
> probably ok but adds a lot of clutter with not much gain. How about
> starting with
>
> const float ratioW = 0.6;
> const float ratioH = 0.6;
>
> .. and go from there ?

The constants provide tweak-able parameters that have rationale
behind them. To keep them is to keep information, while to throw
them out is to remove information. I suggest we keep information.

>
> Another thing: if you have really small screens and end up smaller
> than say 600x400 you might want to boost the size again up to the
> screensize - some pixels.

The "- some pixels" is the hard part that will probably fail in a
not insignificant number of cases.

However, what about view->setWindowState( Qt::WindowFullScreen ); ?



More information about the Kphotoalbum mailing list