[KPhotoAlbum] Very experimental image-grouping patch

Martin Höller martin at xss.co.at
Wed Nov 28 15:08:51 GMT 2007


On 28. November 2007 Paul Fleischer wrote:
>
> images = loadImagesFromXML();
> foreach img in images {
>   if( images->parent() != null ) {
>      DB::ImageDB::instance()->info( img->parent() )->addChildImage(
> img->fileName() );
>   }
> }

Why not do the actual work in loadImagesFromXML()? This method aims to   
load all image info from the DB, and has to go through all images anyway.

It could build an additional list of images whith some attributes 
(i.e. "children") still missing and fill in the missing pieces once all 
images exist in memory.

just my 2¢,
- martin
-- 
Martin Höller                   | martin.hoeller at xss.co.at
*x Software + Systeme           | http://www.xss.co.at/
Karmarschgasse 51/2/20          | Tel: +43-1-6060114-30
A-1100 Vienna, Austria          | Fax: +43-1-6060114-71
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20071128/32c9558b/attachment.sig>


More information about the Kphotoalbum mailing list