[KPhotoAlbum] [Bug 145309] make "show this image" load all images in current view

Jan Kundrát jkt at gentoo.org
Thu May 24 23:42:27 BST 2007


Jan Kundrát wrote:
> Yup, I'm aware of that, but I haven't tested it yet so I don't propose 
> the change. I'm not sure how would Viewer react if it's told to show 
> image 123 and images 100 - 110 aren't readable, for example.
> 
> And if we change this, we should do the same for Ctrl+A (select all images).

Please see the attached patch that addresses those two issues and tries
to "skip" those non-existant images when viewing. This auto-skipping
could be a bit confusing because commands like "seek 100 images back"
don't take these "holes" into account...

I've also changed one iterator to a constant one. It compiles and works
fine, so I guess it's a safe change.

Cheers,
-jkt

-- 
cd /local/pub && more beer > /dev/mouth
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: selection-avoid-stat-for-each-file.patch
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20070525/ee56dfa0/attachment.ksh>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20070525/ee56dfa0/attachment.sig>


More information about the Kphotoalbum mailing list