[KPhotoAlbum] [Bug 145309] make "show this image" load all images in current view

Shawn Willden shawn-kimdaba at willden.org
Thu May 24 13:49:31 BST 2007


On Thursday 24 May 2007 04:26:44 am Jan Kundrát wrote:
> * When the application starts, there's one access(path, R_OK) and two
> lstat64() for each file in the DB (or probably rather for each file
> under your image root) -- maybe because I have the "check for new images
> on startup" enabled. Do you use this as well?

Note that Robert has submitted an as-yet-unapplied patch that elminates the 
lstat per file and probably the access as well.

> So, in short, although my patch indeed queries the FS for availability
> of each file in current view, this information should be already
> available in the VFS cache since the program startup.

Unless you're using Robert's optimization, or have "check for new images on 
startup disabled", or are using a file system that can't be cached.

I think I found where the extra accesses are performed:

	files = DB::ImageDB::instance()->currentScope( true );

Changing 'true' to 'false' will disable the up-front disk presence checking.  
Of course, then the viewer will have to handle images that aren't on disk 
gracefully.

	Shawn.



More information about the Kphotoalbum mailing list