[KPhotoAlbum] patches for four bugreports

[Baptiste MATHUS]

2007/6/7, Jan Kundrát <jkt at gentoo.org>:
>
> Hi folks, this is what I have in my local checkout and would like to
> apply:
>
>
> 145158-136374-retag-from-last-image.patch:
> ------------------------------------------
>
> a) Change from "<p>Changes made to current item, really cancel?</p>" to
> "<p>Some items were changed. Do you really want to undo all recent edits
> for each affected image?</p>"
>
> b) Allow to copy tags from previously edited image to current one (works
> only in annotation dialog)
>
>
OK, reviewed this one. Seems good to me, though I think it would be clearer
to add a tooltip at least on the copyPrevious button :

Index:
/home/baptiste/Perso/Projets/KDE-Extragear-Graphics/kphotoalbum/AnnotationDialog/Dialog.cpp
===================================================================
---
/home/baptiste/Perso/Projets/KDE-Extragear-Graphics/kphotoalbum/AnnotationDialog/Dialog.cpp
(revision 676302)
+++
/home/baptiste/Perso/Projets/KDE-Extragear-Graphics/kphotoalbum/AnnotationDialog/Dialog.cpp
(working copy)
@@ -55,6 +55,7 @@
 #include "ShowSelectionOnlyManager.h"
 #include "enums.h"
 #include "MainWindow/DirtyIndicator.h"
+#include <qtooltip.h>

 AnnotationDialog::Dialog::Dialog( QWidget* parent, const char* name )
     : QDialog( parent, name ), _viewer(0)
@@ -163,6 +164,7 @@
     lay6->addWidget( _copyPreviousBut );
     _copyPreviousBut->setIconSet( KGlobal::iconLoader()->loadIconSet(
QString::fromLatin1( "legalmoves" ), KIcon::Desktop, 22 ) );
     _copyPreviousBut->setFixedWidth( 40 );
+    QToolTip::add(_copyPreviousBut, i18n("Copy tags from last image"));
     connect( _copyPreviousBut, SIGNAL( clicked() ), this, SLOT(
slotCopyPrevious() ) );

     lay6->addStretch( 1 );

Apart from this, this feature seems ok.

I also had a look on the "show all when only one selected" and the "stop
video playback" adds. No difference for me for the first (I have all my
images on disk, so I guess I'm not the right person to test it :p), for the
second one, just great ! I always thought it was a pity the sound didn't
stop but never took the time to report it :-/.

Thanks again, Jan.

-- 
Baptiste <Batmat> MATHUS
BMathus at Batmat point net - http://batmat.net
---------
Si chacun de nous a une idée et que nous les partageons, nous
repartirons tous les deux avec deux idées... C'est ça le Libre.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20070616/335c9148/attachment.htm>