[KPhotoAlbum] some more remarks/suggestions

Jesper K. Pedersen blackie at blackie.dk
Sat Sep 23 08:07:14 BST 2006

On Thursday 31 August 2006 18:02, Christoph Moseler wrote:
| Hi Jesper,
| some more remarks/suggestions.
| - I don't think it's a good idea to let the user alter the folder
| structure in the annotation dialog. Also the possibility to assign
| images to folders doesn't make sense. Maybe the folder category should
| be removed completly from the annotation dialog.
Ack. Fixed
| - It should be possible to unset the image that is used for a category
| in the "Configure Category Image"-dialog of the viewer. If once an image
| is set, the user can not undo it. The unset-function should delete the
| .jpg in the kpa_home/CategoryImages directory.
Agree, but it is really such a minor bug, that it is gonna live on, I'm 

| - When renaming a category in the Settings-Dialog -> Categories, the
| .jpg-file in the CategoryImages directory is not renamed. Maybe it is
| better to create the category-images with a random filename and add a
| new property to the categories for this filename. The new property
| should than be saved in the database. That would also fix the problem,
| that occurs, when the user desides to not save the xml-file after
| renaming a (sub-)category (images is renamed, but the new name of the
| category is not saved in the DB).
ack, and fixed.

| - It would be great if the "rescan for images" functionallity also could
| exclude entire directories instead of certain images.
| void NewImageFinder::searchForNewFiles( const QDict<void>& loadedFiles,
| QString directory )
| {
|   [snip]
|          else if ( fi.isDir() )  {
| +            QString dirName = file.mid( imageDir.length()+1 );
| +            if ( ! DB::ImageDB::instance()->isBlocking( dirName ) )
|                  searchForNewFiles( loadedFiles, file );
|          }
|      }
| }
| The code above would do that, but of course there must be something
| where a directory can be added to the blocklist (instead vi index.xml ;-) 
| )
And as mentioned in other threads, I'll only accept this patch if it includes 
a configuration dialog.

Cheers and thanks

More information about the Kphotoalbum mailing list