[KPhotoAlbum] New snapshot + feauture freeze + message freeze

[Martin Hoeller]

On 20 Mär 2006, Martin Hoeller wrote:

> On 19 Mär 2006, Jesper K. Pedersen wrote:
> 
> > KPhotoAlbum has now entered complete freeze (modulo bug fixes), so please 
> > download a snapshot, this might very well be your final chance to find bugs 
> > before they will annoy you for the better part of the rest of the year.
> 
> Here we go...
> 
> > 	* BUGFIX: The annotation window no longer crashes when reseting
> > 	its layout.
> 
> Sorry, it does :-(

Found the bug: MainView::configImages() executes the dialog and queries
afterwards if thumbnails should be reloaded. If Reset Layout is invoked
in the meanwhile, the dialog is closed and _annotationDialog set to NULL.
This leads to a call of thumbnailShouldReload() with a NULL this-pointer.

The following should fix it, but thumbnails are never reloaded if the layout
is reset.

--- mainview.cpp        (revision 520704)
+++ mainview.cpp        (working copy)
@@ -327,7 +327,7 @@
 {
     createAnnotationDialog();
     _annotationDialog->configure( list,  oneAtATime );
-    if ( _annotationDialog->thumbnailShouldReload() )
+    if ( _annotationDialog &&_annotationDialog->thumbnailShouldReload() )
         reloadThumbnails(true);
 }


- martin

-- 
    mailto:martin.hoeller at xss.co.at  | "Lebensgefährtin" ist ein Wort,
http://stud3.tuwien.ac.at/~e9926483  |      das von Lebensgefahr
                       icq:45563199  |        abgeleitet ist.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20060320/b5290cba/attachment.sig>