[KPhotoAlbum] some more remarks/suggestions

Christoph Moseler forums at moseler.net
Thu Aug 31 17:02:08 BST 2006


Hi Jesper,

some more remarks/suggestions.

- I don't think it's a good idea to let the user alter the folder 
structure in the annotation dialog. Also the possibility to assign 
images to folders doesn't make sense. Maybe the folder category should 
be removed completly from the annotation dialog.

- It should be possible to unset the image that is used for a category 
in the "Configure Category Image"-dialog of the viewer. If once an image 
is set, the user can not undo it. The unset-function should delete the 
.jpg in the kpa_home/CategoryImages directory.

- When renaming a category in the Settings-Dialog -> Categories, the 
.jpg-file in the CategoryImages directory is not renamed. Maybe it is 
better to create the category-images with a random filename and add a 
new property to the categories for this filename. The new property 
should than be saved in the database. That would also fix the problem, 
that occurs, when the user desides to not save the xml-file after 
renaming a (sub-)category (images is renamed, but the new name of the 
category is not saved in the DB).

- It would be great if the "rescan for images" functionallity also could 
exclude entire directories instead of certain images.

void NewImageFinder::searchForNewFiles( const QDict<void>& loadedFiles, 
QString directory )
{
  [snip]
         else if ( fi.isDir() )  {
+            QString dirName = file.mid( imageDir.length()+1 );
+            if ( ! DB::ImageDB::instance()->isBlocking( dirName ) )
                 searchForNewFiles( loadedFiles, file );
         }
     }
}

The code above would do that, but of course there must be something 
where a directory can be added to the blocklist (instead vi index.xml ;-)  )

Cheers,
Christoph





More information about the Kphotoalbum mailing list