[KimDaBa] Strange crash with KimDaBa and SUSE 9.1 with KDE 3.3.2

Robert L Krawitz rlk at alum.mit.edu
Wed Dec 29 18:08:09 GMT 2004


   Date: Wed, 29 Dec 2004 13:00:15 -0500
   From: Robert L Krawitz <rlk at alum.mit.edu>

   #ifdef QT_HAVE_MAX_IMAGE_SIZE
	    //
	     QSize max_size = QImage::maxImageSize();
	     if (max_size.width() > 0 && max_size.width() < (int) li.width()) {
	       max_size.setWidth(li.width());
	      QImage::setMaxImageSize(max_size);
	     }
	     if (max_size.height() > 0 && max_size.height() < (int) li.height()) {
	       max_size.setHeight(li.height());
	       QImage::setMaxImageSize(max_size);
	     }
   #endif

I thought about it some more.  This code must come out, no two ways
about it.  The version in imageloader.cpp doesn't know the actual size
of the image; it only knows the desired size for e. g. thumbnail
purposes.  So there's no way this can work.  What's more, it means
that a binary built on a SUSE system can't be used anywhere else, due
to the incompatible symbols used.

This should simply be documented, until SUSE (hopefully) removes it
altogether.

-- 
Robert Krawitz                                     <rlk at alum.mit.edu>

Tall Clubs International  --  http://www.tall.org/ or 1-888-IM-TALL-2
Member of the League for Programming Freedom -- mail lpf at uunet.uu.net
Project lead for Gimp Print   --    http://gimp-print.sourceforge.net

"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton



More information about the Kphotoalbum mailing list