[Korganizer-devel] [Bug 256003] New: Virtual keyword missing from save() method in kdepimlibs/kcal/resourcecalendar.h

[Kumaran Santhanam]

https://bugs.kde.org/show_bug.cgi?id=256003

           Summary: Virtual keyword missing from save() method in
                    kdepimlibs/kcal/resourcecalendar.h
           Product: kontact
           Version: unspecified
          Platform: Fedora RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: NOR
         Component: calendar
        AssignedTo: korganizer-devel at kde.org
        ReportedBy: kumaran at alumni.stanford.org


Version:           unspecified (using KDE 4.5.2) 
OS:                Linux

On line 107 of kdepimlibs/kcal/resourcecalendar.h:

bool save( Incidence *incidence = 0 );

should be:

virtual bool save( Incidence *incidence = 0 );

There are several derived objects (such as ResourceCached) which overload the
save() method with the assumption that it is virtual.

Because of this bug, operations such as right-click Save do not work properly,
since the derived virtual method is never called.  The consequence is that the
user thinks data was saved when it wasn't, potentially resulting in data loss.


Reproducible: Always

Steps to Reproduce:
1. Turn on KDE debugging
2. Right-click a calendar and select Save


Actual Results:  
The overloaded save() method of ResourceCached is not called, causing the
calendar not to be saved.


Expected Results:  
The overloaded save() method of ResourceCached should be called, immediately
saving the calendar.

This is a quick fix that would be much appreciated for the next point release.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.