[Korganizer-devel] [Bug 81689] I would like to have scrollbar in the month view. Also the mouse wheel should work.

[chiefaua]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=81689         
tom_t gmx at changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23419|0                           |1
        is obsolete|                            |



------- Additional Comments From tom_t gmx at  2008-02-07 21:02 -------
Created an attachment (id=23466)
 --> (http://bugs.kde.org/attachment.cgi?id=23466&action=view)
Next version of the patch

Hi

This is the next version of the patch. This time it covers other bugs too:

http://bugs.kde.org/show_bug.cgi?id=148753 (Scroll bars in month view cells
useless because of faded content)

http://bugs.kde.org/show_bug.cgi?id=150067 (page down/up should scroll month
view by a month)

in some points http://bugs.kde.org/show_bug.cgi?id=52517 (Month view very
difficult to read)


MonthViewCell's are now styled using Qt style sheets. Therefore I have defined
some properties for the MonthViewCell and use these properties in the style
sheet. The style sheet is reapplied whenever these properties change.
I made this change because formerly all the styling-stuff was spread out all
over the MonthViewCell class. This was quite confusing and led to some
not-so-predictable results. Style sheets group all the styling information and
provide a more flexible styling.
I will attach a screenshot of the new month view.

There were also some minor changes, the most important I currently think of:
I removed mDateToCell from KOMonthView. This map was used to associate QDates
to MonthViewCells. But there is a QVector holding all the MonthViewCell-pointer
anyway, and you can easily compute the index in this array (using
QDate::daysTo()). I tried to benchmark the performance difference, and
computing the index is about 2 to 3 times faster as using the map. And getting
rid of the map saves me from quite a lot book-keeping work while scrolling the
view ;-).

Another issue was displaying of Todo's in the monthview: I had some problems
with all-day Todo's, but that's resolved now. (I don't know if the problem
existed before).

And while waiting for the compilation of the current KDE trunk, I added an
option to turn off the display of icons in the events. There was some bug
report around about that, but I couldn't find it right now...

Possibly there were some other minor changes I currently not think of ;-)


It would be cool if somebody could look at the patch, and maybe even test it
briefly. 

I also plan to add support for selecting more than one cell in the month view
(a date range I guess...) and to improve display of multi-day-events. Should I
just improve my patch for this or create another one (which would be quite
difficult, I think...)?

Regards

Thomas