No subject
Sat Jan 29 00:45:17 CET 2011
I saw that for yahoo - webcam images are converted by running an
external program. Personally I am not ok with this since running an
external program every 0.X seconds is a bit expensive. Also, not to
mention using disk files (at least pushing directly into the program
and reading its output would have been better).
Also - I saw that inviteWebcam action was checking for presence of
jasper program - but requestWebcam should also have done that. Not
to mention that if a yahoo contact just invites you to see his cam,
you might get a feedback of missing program after accepting to
invitation. Not necessarily a big deal, though.
Original patch by Cristi Posoiu <cristi.posoiu AT gmail>, thanks!
This commit is a forward-port of r1217895 to the 4.6 branch.
REVIEW: 6312
CCBUG: 244135
M +4 -1 CMakeLists.txt
M +3 -1 libkyahoo/CMakeLists.txt
A libkyahoo/webcamimgformat.cpp [License: LGPL (v2+)]
A libkyahoo/webcamimgformat.h [License: LGPL (v2+)]
M +8 -30 libkyahoo/webcamtask.cpp
M +1 -15 yahoocontact.cpp
M +10 -35 yahoowebcam.cpp
M +0 -3 yahoowebcam.h
WebSVN link: http://websvn.kde.org/?view=rev&revision=1217896
--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the kopete-bugs
mailing list