[kopete-bugs] [Bug 233330] Kopete sends <p> tags around messages

[Michael Zanetti]

https://bugs.kde.org/show_bug.cgi?id=233330





--- Comment #8 from Michael Zanetti <michael_zanetti gmx net>  2010-05-09 14:17:59 ---
Created an attachment (id=43397)
 --> (http://bugs.kde.org/attachment.cgi?id=43397)
Fix for OTR plugin with xml tags and opportunistic mode.

(In reply to comment #7)
> Created an attachment (id=43379)
 --> (http://bugs.kde.org/attachment.cgi?id=43379) [details]
> possible fix
> 
> a possible fix for all issues (not 100% sure about issue #1, but issue #2
> should be fixed).
> please note that I'm NOT familiar with the OTR plugin, thus this may contain
> bugs
> 

Thanks for your investigations. Unfortunately while your patch has a good
approach, it doesn't seem to fix this here but additionally breaks other
things.

Using your patch as input I have investiged a little further and hope to have
produced something usable now.

The attached patch should fix all issues with <p> tags. However, it definitely
breaks OTR opportunistic mode if the user enables rich text formatting. I see
no way to support both with current kopete and libotr. Instead, this fix tries
to have opportunistic mode working for plaintext messages, but have working
rich text if the user wants that (at the cost of broken opportunistic mode).

Note: RTF with jabber seems to be badly broken here also if the OTR plugin is
completely disabled... It would be nice if some of you could test this with
other protocols too.

Here is a little check list what to test:
- Are messages sent out correctly (no <p> tags etc)?
- Are user-typed tags and special chars handled and delivered corectly (no lost
characters or tags like  <,>,ä,ö,&,? etc.)?
- Is an OTR session automatically established if both clients have
opportunistic mode enabled?
- Is Rich Text Formating working?

If no furher problems with this patch are reported, I will commit it before
4.4.4.

Thanks

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.