[kopete-bugs] [Bug 233330] Kopete sends <p> tags around messages

[Martin Blumenstingl]

https://bugs.kde.org/show_bug.cgi?id=233330


Martin Blumenstingl <darklight.xdarklight at googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darklight.xdarklight at google
                   |                            |mail.com,
                   |                            |michael_zanetti at gmx.net




--- Comment #6 from Martin Blumenstingl <darklight xdarklight googlemail com>  2010-05-09 00:11:46 ---
Hi,

I was just investigating this issue (as I find it pretty annoying).
some information about my kopete first:
Version:           1.0.0 (using KDE 4.4.3 from Arch's 'extra' repository)

now from what I can tell so far is that it looks like we're having two
different bugs in here.
the first one is the one from the original author
the second one is probably the one reported by Andrea Scarpino.

I found out that there's a regression in KDE 4.4.3's kopete.
it is caused by this commit (thus I'm CC'ing mzanetti ;)):
http://websvn.kde.org/branches/KDE/4.4/kdenetwork/kopete/plugins/otr/otrplugin.cpp?r1=1117326&r2=1117354

the issue here is that msgBody is either the parsedBody() (before KDE 4.4.1 it
was the encryptedBody() of a message)
I'm not 100% sure why parsedBody() returns HTML code, but anyway...

unfortunately mzanetti is calling setPlainBody(msgBody) - but since the text
contains <p>'s it's sent out directly to the friend you're chatting with right
now.

now to the second issue:
I believe there's a bug in OTRPlugin::slotOutgoingMessage( Kopete::Message& msg
):
why is setPlainBody/setHtmlBody being called unconditionally?
there's one case where it's valid (this call should be valid:
msg.setPlainBody(i18n("An error occurred while encrypting the message."));)
also I think msgBody and cachedBody should be set conditionally (depending on
the message's type we should call plainBody() or escapedBody()/parsedBody())

please note that I'm not 100% sure if the explanation of the second issue is
100% correct, someone with more knowledge about the otr plugin might want to
take a look at it ;)

Regards,
Martin

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.