[kopete-bugs] [Bug 229611] New: kopete always connects with empty password for protocols with blank passwords allowed, even if password is saved in config

[H.H.]

https://bugs.kde.org/show_bug.cgi?id=229611

           Summary: kopete always connects with empty password for
                    protocols with blank passwords allowed, even if
                    password is saved in config
           Product: kopete
           Version: unspecified
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: kopete-bugs at kde.org
        ReportedBy: cyberbeat at gmx.de


Version:           1.0.0 (using 4.4.00 (KDE 4.4.0) "release 222",
KDE:KDE4:Factory:Desktop / openSUSE_11.2)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.31.5-0.1-desktop

I think I found the problem in websvn in file kopetepasswordedaccount.cpp (see
my comments, I am still not sure):

55 void Kopete::PasswordedAccount::connect( const Kopete::OnlineStatus&
initialStatus )
56    {
57           
58            d->initialStatus = initialStatus;

// here I think the password is not filled initially:
59            QString cached = password().cachedValue();

// so, "cached" is allways empty, and for normal accounts this is skipped
// but for my irc protocol with empty passwords allowed this is always true,
and a password dialog will never be shown, and so the cached value will always
be empty?
60            if( !cached.isNull() || d->password.allowBlankPassword() )
61            {
62                    connectWithPassword( cached );
63                    return;
64            }
65    
66            QString prompt = passwordPrompt();

//here the password is fetched from config, so the cache is filled.
//I think the allowBlankPassword-Case should be handled here instead of above
67            Kopete::Password::PasswordSource src = password().isWrong() ?
Kopete::Password::FromUser : Kopete::Password::FromConfigOrUser;
68    
69            password().request( this, SLOT( connectWithPassword( const
QString & ) ), accountIcon( Kopete::Password::preferredImageSize() ), prompt,
src );
70    }

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.