[kopete-bugs] [Bug 246156] New: kopete connection timeout around every 3 minutes (jabber)

[Ike Devolder]

https://bugs.kde.org/show_bug.cgi?id=246156

           Summary: kopete connection timeout around every 3 minutes
                    (jabber)
           Product: kopete
           Version: 1.0.0
          Platform: Archlinux Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: libkopete
        AssignedTo: kopete-bugs at kde.org
        ReportedBy: ike.devolder at gmail.com


Created an attachment (id=49636)
 --> (http://bugs.kde.org/attachment.cgi?id=49636)
proposed patch to make it reachable

Version:           1.0.0 (using KDE 4.4.5) 
OS:                Linux

kopete(3401) Kopete::SocketTimeoutWatcher::ackTimeoutCheck:
info.tcpi_last_ack_recv  48336992 
kopete(3401) Kopete::SocketTimeoutWatcher::ackTimeoutCheck:
info.tcpi_last_data_sent  0 
kopete(3401) Kopete::SocketTimeoutWatcher::ackTimeoutCheck: mTimeoutThreshold 
15000 
kopete(3401) Kopete::SocketTimeoutWatcher::ackTimeoutCheck: getSockOpt == 0 
kopete(3401) Kopete::SocketTimeoutWatcher::ackTimeoutCheck:
info.tcpi_last_ack_recv  1 
kopete(3401) Kopete::SocketTimeoutWatcher::ackTimeoutCheck:
info.tcpi_last_data_sent  32767 
kopete(3401) Kopete::SocketTimeoutWatcher::ackTimeoutCheck: mTimeoutThreshold 
15000 
kopete(3401) Kopete::SocketTimeoutWatcher::ackTimeoutCheck: getSockOpt == 0 
kopete(3401) Kopete::SocketTimeoutWatcher::ackTimeoutCheck: Connection timeout
for   QHostAddress( "193.168.4.117" )  
kopete(3401) Kopete::SocketTimeoutWatcher::ackTimeoutCheck:
info.tcpi_last_ack_recv  38237024 
kopete(3401) Kopete::SocketTimeoutWatcher::ackTimeoutCheck:
info.tcpi_last_data_sent  4294967295 
kopete(3401) Kopete::SocketTimeoutWatcher::ackTimeoutCheck: mTimeoutThreshold 
15000 
kopete(3401) Kopete::SocketTimeoutWatcher::ackTimeoutCheck: getSockOpt == 0


there is some unreachable code in kopetesockettimeoutwatcher.cpp

you will never reach the 
else if ( info.tcpi_last_ack_recv < info.tcpi_last_data_sent )

since the if will be sattisfactory for an 'false' connection timeout

Reproducible: Always

Steps to Reproduce:
just connect to an jabber server

Actual Results:  
from time to time i get a "false" connection timeout

Expected Results:  
connectiontimeout

just stay online

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.