[kopete-bugs] [Bug 198899] New: jdns.c:list_delete() collides with list_delete() in libmysqlclient_r.so

[Daniel Eklöf]

https://bugs.kde.org/show_bug.cgi?id=198899

           Summary: jdns.c:list_delete() collides with list_delete() in
                    libmysqlclient_r.so
           Product: kopete
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: crash
          Priority: NOR
         Component: general
        AssignedTo: kopete-bugs at kde.org
        ReportedBy: daniel at ekloef.se


Version:           0.70.90 (using Devel)
Compiler:          gcc-4.4.0 
OS:                Linux
Installed from:    Compiled sources

When connecting to my Jabber account, kopete crashes:

Thread 1 (Thread 0x7fd23b93e760 (LWP 5536)):
[KCrash Handler]
#5  0x00007fd2310a26c0 in list_delete () from /usr/lib64/libmysqlclient_r.so.16
#6  0x00007fd222686c01 in jdns_session_delete () from
/usr/lib64/kde4/kopete_jabber.so

The call to list_delete in mysql looked weired and I couldn't understand why
kopete would do that. Turns out there is a local function in
kopete/protocols/jabber/libiris/iris/jdns/jdns.c that it intended to call. Only
problem is that list_delete in jdns.c isn't marked as static, making it choose
list_delete from mysql instead!

This patch fixes the issue for me:

Index: protocols/jabber/libiris/iris/jdns/jdns.c
===================================================================
--- protocols/jabber/libiris/iris/jdns/jdns.c   (revision 991182)
+++ protocols/jabber/libiris/iris/jdns/jdns.c   (working copy)
@@ -486,7 +486,7 @@
        return l;
 }

-void list_delete(list_t *l)
+static void list_delete(list_t *l)
 {
        int n;
        if(!l)

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.