[kopete-bugs] [Bug 186296] Kopete DBus bad behaviour with linked addressbook contacts

[Rettich]

https://bugs.kde.org/show_bug.cgi?id=186296


Rettich <sebastian.radish at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sebastian.radish at gmx.de




--- Comment #1 from Rettich <sebastian radish gmx de>  2009-04-03 16:58:17 ---
Kopete DBus has much improved since KDE 4.0 but your are right. This is still a
bug.

I had a look through the source and found something interesting:

The dbus methode conacts() returns a list of !!meta!! contacts. So gG2oDHcPwx
is the meta contanct id.
The dbus methode contactProperties() calls
KopeteDBusInterfacePrivate::findContact() and this methode calls
Kopete::ContactList::self()->findMetaContactByContactId(). This means:
conactProperties() wants a contact id and not a !!meta!! contact id.

I think changing the line:
contact = Kopete::ContactList::self()->findMetaContactByContactId(
                nameOrId);
to:
contact = Kopete::ContactList::self()->metaContact(
                nameOrId);
in:
kopete/kopetedbusinterface_p.cpp will solve the problem.
Btw: The same problem exists in sendMessage(), getDisplayName(), etc. I think
this change will solve those problems, too.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.