[kopete-bugs] [Bug 178889] New: Now Listening plugin crashes or behaves strangly because of inconsistent commenting

[Erik van 't Wout]

http://bugs.kde.org/show_bug.cgi?id=178889

           Summary: Now Listening plugin crashes or behaves strangly because
                    of inconsistent commenting
           Product: kopete
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: crash
          Priority: NOR
         Component: general
        AssignedTo: kopete-bugs at kde.org
        ReportedBy: erik at hofhom.nl


Version:           4.1.85 (4.2 beta 2) (using Devel)
Compiler:          gcc-4.1.2 
OS:                Linux
Installed from:    Compiled sources

While hacking around in the now-listening plugin, I found the following
inconsistency in the sources (4.1.85), which can cause a crash, or strange
behaviour:

kdenetwork-4.1.85/kopete/plugins/nowlistening/nowlisteningplugin.cpp, lines
111-114:

// set up known media players
d->m_mediaPlayerList.append( new NLKscd() );
//d->m_mediaPlayerList.append( new NLNoatun() );
d->m_mediaPlayerList.append( new NLJuk() );


kdenetwork-4.1.85/kopete/plugins/nowlistening/nowlisteningpreferences.cpp,
lines 53-56:

// Fill the media player listbox.
preferencesDialog->kcfg_SelectedMediaPlayer->insertItem(QString::fromUtf8("Kscd"));
preferencesDialog->kcfg_SelectedMediaPlayer->insertItem(QString::fromUtf8("Noatun"));
preferencesDialog->kcfg_SelectedMediaPlayer->insertItem(QString::fromUtf8("Juk"));


Since Noatun support is disabled in *plugin.cpp and enabled in *preferences.cpp
(and the whole thing is QList and index based), this will (in certain
circumstances) cause the wrong plugin being used and in the worst case cause a
crash (if the last plugin is selected in the configuration dialog).


-- 
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.