[konversation] [Bug 445154] New: hyperlink truncated for an email address with long TLD

[Jonathan Wakely]

https://bugs.kde.org/show_bug.cgi?id=445154

            Bug ID: 445154
           Summary: hyperlink truncated for an email address with long TLD
           Product: konversation
           Version: 1.8.21041
          Platform: Fedora RPMs
                OS: Linux
            Status: REPORTED
          Severity: minor
          Priority: NOR
         Component: ircview
          Assignee: argonel at gmail.com
          Reporter: zilla at kayari.org
                CC: konversation-devel at kde.org
  Target Milestone: ---

SUMMARY

An email address such as test at foo.invalid is not displayed correctly, the
hyperlink doesn't include the final 'd'

That email address isn't valid, but the same thing happens for any address at
foo.website or foo.computer or foo.academy or any other TLD longer than 6
characters.

STEPS TO REPRODUCE
1.  send an IRC message containing foo at test.abcdefghi
2. look at the hyperlink konversation creates
3. 

OBSERVED RESULT

Only "foo at test.abcdef" is hyperlinked.

EXPECTED RESULT

The whole email address should be a hyperlink.

SOFTWARE/OS VERSIONS
Konversation: 1.8.21041
KDE Plasma Version: 5.22.5
KDE Frameworks Version: 5.85.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION

This seems to be a bug in the urlPattern regex:
https://github.com/KDE/konversation/blob/9288fab598d84ceaf4ff1d5a782adf6882e2ec57/src/common.h#L24

The relevant part for email addresses seems to be
@[a-z0-9.\\-]+[.][a-z]{1,5}[^...] which assumes a maximum length of 5+1
Maybe changing the {1,5} to simply + would work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.