[konversation] [Bug 446673] Channel Settings, Modes tab "User Limit" QSpinBox uses default max=99, messing up any higher setting by /cmode +l NNN

[Friedrich W. H. Kossebau]

https://bugs.kde.org/show_bug.cgi?id=446673

Friedrich W. H. Kossebau <kossebau at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/netw
                   |                            |ork/konversation/commit/074
                   |                            |f80e2dcefdc6cd0b68714021481
                   |                            |ee35b7df30
         Resolution|---                         |FIXED
   Version Fixed In|                            |1.8.21121
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from Friedrich W. H. Kossebau <kossebau at kde.org> ---
Git commit 074f80e2dcefdc6cd0b68714021481ee35b7df30 by Friedrich W. H.
Kossebau.
Committed on 18/12/2021 at 23:27.
Pushed by kossebau into branch 'release/21.12'.

Channel Settings UI: bump max value of "User limit" to 99999

Max value was the default 99, which would result in...
a) any higher value read from the channel mode being reset to 99
b) not allow users to set higher values if wanted.

As applying the channel settings from the dialog always picks all the
values of the dialog, also those not edited, in case of a) this also
would mean changing the user limit in the channel to 99 then.

RFCs are not known to define a max user limit, so this is server defined.
While there is no path explored to query any max user limit capabilities,
and servers implementations seems to just map too high numbers to random
possible ones, there is no well defined max value to be used for the
dialog.

Using 99999 as arbitrary value should serve for now all expected use-cases.
To be raised later if there is respective feedback.

FIXED-IN: 1.8.21121

M  +3    -0    src/viewer/channeloptionsui.ui

https://invent.kde.org/network/konversation/commit/074f80e2dcefdc6cd0b68714021481ee35b7df30

-- 
You are receiving this mail because:
You are the assignee for the bug.