[konversation] [Bug 371475] New: OSD textBuffer has unbounded size

[Jason Tibbitts via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=371475

            Bug ID: 371475
           Summary: OSD textBuffer has unbounded size
           Product: konversation
           Version: 1.6.2
          Platform: Fedora RPMs
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: notifications
          Assignee: konversation-devel at kde.org
          Reporter: tibbs at math.uh.edu

I use znc and let it buffer messages while I'm offline, so when konversation
connects it may get hundreds of messages sent all at once.  This results in the
OSD going through messages, one at a time, for quite a long time.  (Really,
I've had it go for several hours before.)

In viewer/osd.cpp, OSDWidget::show() will append the string to be shown to
textBuffer if the timer hasn't expired.  It seems to me that a quick check of
textBuffer.size() to limit the queue to something like 20, or (60 / (the
message display time in seconds)) would solve the problem and not really lose
any useful information, since any messages you'd display after that would be
somewhat out of date.

It's been over 20 years since I wrote any C++ so I don't have a patch to
contribute, but I figured I'd open this so I don't lose the bit of research I
just did.  If I can find the time I'll try to hack something up, but of course
I don't really know what I'm doing.

Reproducible: Always

Steps to Reproduce:
Connect to ZNC with a lot of buffered content.

Actual Results:  
OSD flashes through messages for five or six hours.

Expected Results:  
OSD flashes through some content, but only queues enough messages to run for
about a minute.

-- 
You are receiving this mail because:
You are the assignee for the bug.