Review Request 129132: Change text to "+" on Add Identitiy QPushbutton

[Albert Astals Cid]

> On Oct. 9, 2016, 12:15 p.m., Peter Simonsson wrote:
> > What is this supposed to fix? Seems to mostly break things here...
> 
> Nilesh Kokane wrote:
>     The Pushbutton should atleast have a text/icon to indicate as to what it does. But that wasn't a case.
> 
> Peter Simonsson wrote:
>     Then something is wrong with your installation cause the button has an icon already.
> 
> Nilesh Kokane wrote:
>     Oops, I just ran package installed version and I could see the icon.
>     Sorry for the noise.

Should this be discarded then?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129132/#review99873
-----------------------------------------------------------


On Oct. 9, 2016, 11:53 a.m., Nilesh Kokane wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129132/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2016, 11:53 a.m.)
> 
> 
> Review request for Konversation and Peter Simonsson.
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   src/identitydialog.ui 68e255c 
> 
> Diff: https://git.reviewboard.kde.org/r/129132/diff/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> Nilesh Kokane
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20161109/46597e12/attachment.html>