[Konversation-devel] Review Request 127967: Port all instances of Kauthorized action/shell_command to shell_command

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127967/
-----------------------------------------------------------

(Updated May 23, 2016, 6:24 a.m.)


Status
------

This change has been marked as submitted.


Review request for Konversation.


Changes
-------

Submitted with commit 500ac45aac69c09e174c1f308067a062bc6b83a6 by David Edmundson to branch master.


Repository: konversation


Description
-------

The KAuthorized key to prevent shell access according the documentation
is simply "shell_action" not "action/shellAction" so should use
authorize not authorizeKAction

This appears to have come about as part of a porting bug when going from
KApplication::authorize to KAuthorized in kdelibs3 to kdelibs4.

To currently block shell access a sysadmin currently needs to
have both keys set already, so we can be confident it won't have any
actual compatibility problems.


Diffs
-----

  src/mainwindow.cpp 9e9887737490f3439b7f2a162f389a04276577d9 

Diff: https://git.reviewboard.kde.org/r/127967/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20160523/afe12d5b/attachment.html>