[Konversation-devel] Review Request 127967: Port all instances of Kauthorized action/shell_command to shell_command
David Edmundson
david at davidedmundson.co.uk
Thu May 19 14:53:39 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127967/
-----------------------------------------------------------
Review request for Konversation.
Repository: konversation
Description
-------
The KAuthorized key to prevent shell access according the documentation
is simply "shell_action" not "action/shellAction" so should use
authorize not authorizeKAction
This appears to have come about as part of a porting bug when going from
KApplication::authorize to KAuthorized in kdelibs3 to kdelibs4.
To currently block shell access a sysadmin currently needs to
have both keys set already, so we can be confident it won't have any
actual compatibility problems.
Diffs
-----
src/mainwindow.cpp 9e9887737490f3439b7f2a162f389a04276577d9
Diff: https://git.reviewboard.kde.org/r/127967/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20160519/c8953eb8/attachment.html>
More information about the Konversation-devel
mailing list