[Konversation-devel] Review Request 128321: searchbar: Use QIcon::fromTheme to get next/previous icons
Eike Hein
hein at kde.org
Thu Jun 30 11:14:16 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128321/#review96970
-----------------------------------------------------------
Ship it!
Ship It!
- Eike Hein
On June 29, 2016, 3:34 p.m., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128321/
> -----------------------------------------------------------
>
> (Updated June 29, 2016, 3:34 p.m.)
>
>
> Review request for Konversation.
>
>
> Bugs: 361833
> https://bugs.kde.org/show_bug.cgi?id=361833
>
>
> Repository: konversation
>
>
> Description
> -------
>
> The icons on the next and previous buttons in the searchbar were
> missing because QIcon(QString) expects a path containing a file
> name, but was given an icon name.
>
> BUG: 361833
>
>
> Diffs
> -----
>
> src/viewer/searchbar.cpp a5f0f69
>
> Diff: https://git.reviewboard.kde.org/r/128321/diff/
>
>
> Testing
> -------
>
> Icons appear on the buttons.
>
>
> Thanks,
>
> Heiko Becker
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20160630/2e71fe99/attachment.html>
More information about the Konversation-devel
mailing list