[Konversation-devel] Review Request 128467: Fix the config dialog size and add scollbars when it doesn't fit the screen

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128467/#review97597
-----------------------------------------------------------




src/config/configdialog.cpp (line 54)
<https://git.reviewboard.kde.org/r/128467/#comment65795>

    This will no longer be correct when the dialog is moved to another screen. You should maybe set it in showEvent so it gets the then-current screen.


- Eike Hein


On July 16, 2016, 12:48 p.m., Olivier Churlaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128467/
> -----------------------------------------------------------
> 
> (Updated July 16, 2016, 12:48 p.m.)
> 
> 
> Review request for Konversation and Eike Hein.
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
> This is the same patch like https://git.reviewboard.kde.org/r/128464/
> 
> 
> Diffs
> -----
> 
>   src/config/configdialog.cpp 6dd99bb 
> 
> Diff: https://git.reviewboard.kde.org/r/128467/diff/
> 
> 
> Testing
> -------
> 
> Compiles and buttons are accessible.
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20160719/11d86776/attachment.html>