Review Request 127022: Fix build on Windows with MSVC 2015.

Kevin Funk kfunk at kde.org
Sat Aug 13 16:21:37 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127022/#review98357
-----------------------------------------------------------



Took a slightly different approached, pushed those trivial changes:

```
commit 180c65d0611a9b729bf2038d773af949a9f59741
Author: Kevin Funk <kfunk at kde.org>
Date:   Sat Aug 13 18:16:24 2016 +0200

    Fix MSVC redefinition warning
    
    Apparently this code is no longer needed

 src/dcc/whiteboardpaintarea.cpp | 5 -----
 1 file changed, 5 deletions(-)

commit f8f45feacb1a0b92e296304ad61fcd726cd2e066
Author: Kevin Funk <kfunk at kde.org>
Date:   Sat Aug 13 18:16:01 2016 +0200

    Make compile under MSVC
    
    No unistd.h there

 src/config/theme_config.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
```

- Kevin Funk


On Feb. 9, 2016, 3:40 p.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127022/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 3:40 p.m.)
> 
> 
> Review request for Konversation.
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
> There was the same problem that is described here: http://stackoverflow.com/questions/1904635/warning-c4003-and-errors-c2589-and-c2059-on-x-stdnumeric-limitsintmax
> 
> 
> Diffs
> -----
> 
>   src/cipher.cpp d69b3890e8d3f4604ad5baeb29b5103a43d24900 
>   src/config/theme_config.cpp 3bce2261aa0da4e4a39440ff4d50755626d559c9 
>   src/dcc/whiteboardpaintarea.cpp 4f8a22b8c7860e33c78cffb53372dadcad6a674d 
> 
> Diff: https://git.reviewboard.kde.org/r/127022/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20160813/206be8e5/attachment.html>


More information about the Konversation-devel mailing list