[Konversation-devel] Review Request 116661: Added option to bypass the proxy when connecting to an IRC server

[Eli MacKenzie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116661/#review86865
-----------------------------------------------------------



src/application.cpp (line 507)
<https://git.reviewboard.kde.org/r/116661/#comment59741>

    Please reverse the words, change ProxyBypass to BypassProxy. Please do this to all instances.



src/irc/server.cpp (line 484)
<https://git.reviewboard.kde.org/r/116661/#comment59747>

    m_socket->setProxy(QNetworkProxy::NoProxy);



src/irc/serverdialogui.ui (line 105)
<https://git.reviewboard.kde.org/r/116661/#comment59742>

    Please invert the sense of this option so that the user is opting out of the global proxy instead of opting in to "no proxy". See https://techbase.kde.org/Projects/Usability/HIG/CheckBox#Behavior. "Use global proxy" would be fine.


Thanks for implementing this!

- Eli MacKenzie


On Oct. 11, 2015, 10:41 a.m., Anselmo L. S. Melo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116661/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2015, 10:41 a.m.)
> 
> 
> Review request for Konversation, Eli MacKenzie and Eike Hein.
> 
> 
> Bugs: 310544
>     https://bugs.kde.org/show_bug.cgi?id=310544
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
> Added an option to the server settings which allows direct connection to the IRC server, bypassing the proxy configured at settings -> configure Konversation -> behavior -> connection. It is usefull for environment where the user connects to an internal IRC server (without using a proxy) and external IRC servers (using the proxy).
> 
> I started implementing this adding all proxy configuration to each IRC server configuration, but, after checking how other popular IRC clients deal with this, I decided to proceed with this 'bypass' approach.
> 
> 
> Diffs
> -----
> 
>   src/application.cpp f66ab8c31f71ac4c2ce4ec221e690a5020619348 
>   src/irc/server.cpp e4a98808d6b20a0f45bf47cf42c1d9859b8cfe03 
>   src/irc/serverdialogui.ui 6871c13dc1cc6bac561df3e607630f36b2fc6465 
>   src/irc/servergroupdialog.cpp 61b8bd96dec2b0901e9fc3d1184d51cce0b2ebde 
>   src/irc/serversettings.h 2b6e068498aa94c20bd871a3add5c0da3e31cfd4 
>   src/irc/serversettings.cpp 53ec203de69ec1cae357a776132ed7952b2a1ed0 
> 
> Diff: https://git.reviewboard.kde.org/r/116661/diff/
> 
> 
> Testing
> -------
> 
> A proxy was configured, then two IRC servers were added: freenode.net (using the proxy) and an internal server (bypassing the proxy). Then konversation was connected to both simultaneously.
> 
> 
> Thanks,
> 
> Anselmo L. S. Melo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20151014/0f5f4a0c/attachment.html>