[Konversation-devel] Review Request 123049: Fix menu i18n by setting application domain for KI18n

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123049/#review77739
-----------------------------------------------------------

Ship it!


Thanks -- please commit to the 1.6 branch and then merge 1.6 into master.

- Eike Hein


On March 19, 2015, 2:40 p.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123049/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 2:40 p.m.)
> 
> 
> Review request for Konversation and Eike Hein.
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
> Application domain needs to be set in order to translate strings in .rc files. When application domain is set, TRANSLATION_DOMAIN macro doesn't need to be defined.
> 
> Another possibility is to add the translationDomain attribute to konversationui.rc. Whichever way you prefer. Setting an application domain has the advantage that there is no need to remember to specify the translation domain in possible new .rc or .kcfg files.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 17d8e7c 
>   src/main.cpp 0203a3b 
> 
> Diff: https://git.reviewboard.kde.org/r/123049/diff/
> 
> 
> Testing
> -------
> 
> Tested that all menus are translated after this change, using KXmlGui from git master. This change does not require KXmlGui from git master, but KXmlGui had an i18n bug that was fixed yesterday. Using this change with older KXmlGui should not result in worse localization. Using newer KXmlGui results in better localization.
> 
> 
> Thanks,
> 
> Lasse Liehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20150319/fc2ee07c/attachment.html>