[Konversation-devel] Review Request 122520: Raise the window also from system tray when activating existing instace

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122520/#review75842
-----------------------------------------------------------



src/mainwindow.cpp
<https://git.reviewboard.kde.org/r/122520/#comment52363>

    I'd recommend making this:
    
    if (!isActiveWindow()) {
        toggleVisibility();
    }
    
    toggleVisibility() also takes care of moving the window to the current virtual desktop if necessary, and goes through KStatusNotifierItem::restore if necessary.


- Eike Hein


On Feb. 11, 2015, 9:50 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122520/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2015, 9:50 a.m.)
> 
> 
> Review request for Konversation and Eike Hein.
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
> When I have konversation already running and hidden in system tray and I try to open it again (not from system tray), it actually does nothing, but it should open already running instance which is just hidden.
> 
> 
> Diffs
> -----
> 
>   src/main.cpp 538f4e3 
>   src/mainwindow.h 2ed99ef 
>   src/mainwindow.cpp 47101fd 
> 
> Diff: https://git.reviewboard.kde.org/r/122520/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20150211/99213166/attachment.html>